Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149164286
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceUtils.java
---
@@ -189,13 +223,18 @@ private static void checkInitCpu(Map<String, Double>
topologyResources, String c
null);
topologyResources.put(Config.TOPOLOGY_COMPONENT_CPU_PCORE_PERCENT, topoCpu);
}
- LOG.debug("Topology Resources {}", topologyResources);
+
+ // If resource is also present in resources map will
overwrite the above
+ if
(jsonObject.containsKey(Config.TOPOLOGY_COMPONENT_RESOURCES_MAP)) {
+ topologyResources.putAll((Map<String, Double>)
jsonObject.get(Config.TOPOLOGY_COMPONENT_RESOURCES_MAP));
+ }
+ LOG.info("Topology Resources {}", topologyResources);
--- End diff --
Is this needed? Should it be debug if it is needed? and can we fix the
indentation?
---
