Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157349435
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutRetryExponentialBackoff.java
---
@@ -290,8 +291,8 @@ public int readyMessageCount() {
}
@Override
- public KafkaSpoutMessageId getMessageId(ConsumerRecord<?, ?> record) {
- KafkaSpoutMessageId msgId = new KafkaSpoutMessageId(record);
+ public KafkaSpoutMessageId getMessageId(ConsumerRecord<?, ?> record,
TopologyContext context) {
--- End diff --
I think if we split KafkaSpoutMessageId we won't need the context here, so
hopefully it won't be a problem to fix.
---
