Github user satishd commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2467#discussion_r157942068
  
    --- Diff: 
external/storm-solr/src/main/java/org/apache/storm/solr/mapper/SolrMapper.java 
---
    @@ -26,6 +26,7 @@
     import java.util.List;
     
     public interface SolrMapper extends Serializable {
    +    void configure();
    --- End diff --
    
    This can break any existing mappers users may have already created. Better 
to have default method to address that.


---

Reply via email to