Github user omkreddy commented on a diff in the pull request:
https://github.com/apache/storm/pull/2467#discussion_r158236702
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/mapper/SolrMapper.java
---
@@ -26,6 +26,7 @@
import java.util.List;
public interface SolrMapper extends Serializable {
+ void configure();
--- End diff --
@satishd Thanks for the review. Since we are using java 1.7 compilation
for 1.x branch, we can not use default methods. We can do it on mater branch. I
don't see any option other than breaking the compatibility here. Let me know
your thoughts.
Updated PR with review comments
---
