Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r158124105
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutEmitTest.java
---
@@ -100,6 +103,8 @@ public void
testNextTupleEmitsFailedMessagesEvenWhenMaxUncommittedOffsetsIsExcee
when(consumerMock.poll(anyLong()))
.thenReturn(new ConsumerRecords<>(records));
+ OffsetAndMetadataStub.committed(consumerMock);
--- End diff --
I tried checking out the branch and running the test without this line. It
seems to still pass. Maybe we should just get rid of it (and
OffsetAndMetadataStub)?
---
