Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r158548050
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutTopologyDeployActivateDeactivateTest.java
---
@@ -0,0 +1,123 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.storm.kafka.spout;
+
+import org.apache.kafka.clients.consumer.ConsumerConfig;
+import
org.apache.storm.kafka.spout.builders.SingleTopicKafkaSpoutConfiguration;
+import org.apache.storm.utils.Time;
+import org.junit.Test;
+
+import java.util.regex.Pattern;
+
+import static org.mockito.Mockito.doNothing;
+import static org.mockito.Mockito.when;
+
+public class KafkaSpoutTopologyDeployActivateDeactivateTest extends
KafkaSpoutAbstractTest {
+ @Override
+ KafkaSpoutConfig<String, String> createSpoutConfig() {
+ return SingleTopicKafkaSpoutConfiguration.setCommonSpoutConfig(
+ KafkaSpoutConfig.builder("127.0.0.1:" +
kafkaUnitRule.getKafkaUnit().getKafkaPort(),
+ Pattern.compile(SingleTopicKafkaSpoutConfiguration.TOPIC)))
+ .setOffsetCommitPeriodMs(commitOffsetPeriodMs)
+ .setRetry(new
KafkaSpoutRetryExponentialBackoff(KafkaSpoutRetryExponentialBackoff.TimeInterval.seconds(0),
KafkaSpoutRetryExponentialBackoff.TimeInterval.seconds(0),
+ maxRetries,
KafkaSpoutRetryExponentialBackoff.TimeInterval.seconds(0)))
+
.setFirstPollOffsetStrategy(KafkaSpoutConfig.FirstPollOffsetStrategy.EARLIEST)
+ .setProp(ConsumerConfig.MAX_POLL_RECORDS_CONFIG,
maxPollRecords)
+ .build();
+ }
+
+ @Test
+ public void
test_FirstPollStrategy_Earliest_NotEnforced_OnTopologyActivateDeactivate()
throws Exception {
+ try (Time.SimulatedTime simulatedTime = new Time.SimulatedTime()) {
+ final int messageCount = 2;
+ prepareSpout(messageCount);
+
+ nextTuple_verifyEmitted_ack_resetCollectorMock(0);
+
+ doNothing().when(consumerSpy).close();
+
+ //Commits offsets during deactivation
+ spout.deactivate();
+
+ verifyAllMessagesCommitted(1, 1);
+
+ spout.activate();
+
+ nextTuple_verifyEmitted_ack_resetCollectorMock(1);
+
+ commitAndVerifyMessagesCommitted(messageCount, 2);
+ }
+ }
+
+ @Test
+ public void
test_FirstPollStrategy_Earliest_NotEnforced_OnPartitionReassignment() throws
Exception {
--- End diff --
I think this test is actually testing something different. The partition
reassignment case is already covered by the test above. This is testing the
case where the spout has crashed and is restarted.
---
