Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2465
  
    Thanks, I missed those changes.
    
    Regarding testing EARLIEST/LATEST, I don't understand why you'd need to 
mock KafkaSpoutConfig. I think it can be tested as an integration test, like 
the ones in SingleTopicKafkaSpoutTest, where you start a spout, emit and commit 
a tuple, deactivate/reactivate it, verify that it can emit and commit the next 
tuple, close the spout and create a new one and verify that the new spout 
starts over/starts at the end.
    
    Alternatively you can do it with mocks like many of the other tests, 
basically doing the same flow but verifying that the spout calls 
seekToBeginning/seekToEnd instead of checking which tuples it emits.
    
    Could you put a +1 on https://github.com/apache/storm/pull/2464 so I can 
merge?


---

Reply via email to