Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r158705775
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -553,9 +567,11 @@ public void fail(Object messageId) {
public void activate() {
try {
subscribeKafkaConsumer();
+ metricsConsumer = new
KafkaConsumer<>(kafkaSpoutConfig.getKafkaProps());
--- End diff --
Why do we need a separate consumer for the metric? Also if we really need
two consumers, you should create this via the factory. Otherwise you prevent us
from stubbing/spying on this consumer.
---
