Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2480#discussion_r158706115
  
    --- Diff: pom.xml ---
    @@ -278,7 +278,7 @@
             <storm.kafka.artifact.id>kafka_2.10</storm.kafka.artifact.id>
     
             <!-- kafka version used by new storm-kafka-client spout code -->
    -        <storm.kafka.client.version>0.10.0.0</storm.kafka.client.version>
    +        <storm.kafka.client.version>0.11.0.2</storm.kafka.client.version>
    --- End diff --
    
    We need to upgrade to at least 0.10.1.0, since that's where the 
`beginningOffsets` and `endOffsets` methods were added to the KafkaConsumer. I 
think upgrading the consumer and adding this patch would probably be a breaking 
change, because the spout won't work with 0.10.0.x client libraries/brokers 
anymore.


---

Reply via email to