[GitHub] storm pull request #2480: [WIP] STORM-2867: Add consumer lag metrics to Kafk...

[srdo]

Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2480#discussion_r158705812
  
    --- Diff: 
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
 ---
    @@ -568,6 +584,8 @@ private void subscribeKafkaConsumer() {
         public void deactivate() {
             try {
                 shutdown();
    +            metricsConsumer.close();
    --- End diff --
    
    I think this belongs in shutdown.


---