Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159061893
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java
---
@@ -31,77 +32,75 @@
public class KafkaOffsetMetric implements IMetric {
private static final Logger LOG =
LoggerFactory.getLogger(KafkaOffsetMetric.class);
- private Map<TopicPartition, OffsetManager> offsetManagers;
- private KafkaConsumer kafkaConsumer;
+ private Supplier<Map<TopicPartition, OffsetManager>>
offsetManagerSupplier;
--- End diff --
Nit: These can be final now
---