Github user omkreddy commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159075538
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -739,4 +764,9 @@ public boolean shouldPoll() {
return !this.pollablePartitions.isEmpty();
}
}
+
+ @VisibleForTesting
+ KafkaOffsetMetric getKafkaOffsetMetric() {
--- End diff --
Agreed, but I feel current approach is simpler. maybe we can evolve when
we add more metrics.
---
