[GitHub] storm pull request #2480: STORM-2867: Add consumer lag metrics to KafkaSpout

[srdo]

Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2480#discussion_r159075727
  
    --- Diff: 
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
 ---
    @@ -739,4 +764,9 @@ public boolean shouldPoll() {
                 return !this.pollablePartitions.isEmpty();
             }
         }
    +
    +    @VisibleForTesting
    +    KafkaOffsetMetric getKafkaOffsetMetric() {
    --- End diff --
    
    Yes, makes sense. Thanks.


---