Github user Ethanlm commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2710#discussion_r208095554
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Slot.java ---
    @@ -1008,6 +1015,13 @@ public void close() throws Exception {
         }
     
         static class DynamicState {
    +        private static final Map<MachineState, Meter> 
workerStateTransition = EnumUtil.toEnumMap(MachineState.class,
    +            machineState -> 
StormMetricsRegistry.registerMeter("supervisor:num-transitions-into-" + 
machineState.toString()));
    +        private static final Map<MachineState, Timer> workerStateDuration 
= EnumUtil.toEnumMap(MachineState.class,
    +            machineState -> StormMetricsRegistry.registerTimer(
    +                    "supervisor:num-transitions-out-" + 
machineState.toString() + "-and-duration-ms")
    --- End diff --
    
    It would be good if we can find a better name


---

Reply via email to