Github user Ethanlm commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2710#discussion_r208340502
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/localizer/AsyncLocalizer.java ---
    @@ -365,6 +384,7 @@ void addReferencesToBlobs(PortAndAssignment pna, 
BlobChangingCallback cb)
             if (!localResourceList.isEmpty()) {
                 getBlobs(localResourceList, pna, cb);
             }
    +        pna.complete();
    --- End diff --
    
    just one more nit: put this outside of this method since the method 
`addReferencesToBlobs` doesn't indicate `complete`


---

Reply via email to