Github user Ethanlm commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2710#discussion_r208279317
  
    --- Diff: 
storm-client/src/jvm/org/apache/storm/daemon/supervisor/ClientSupervisorUtils.java
 ---
    @@ -28,11 +29,14 @@
     import org.apache.storm.shade.org.apache.commons.lang.StringUtils;
     import org.apache.storm.utils.ConfigUtils;
     import org.apache.storm.utils.ObjectReader;
    +import org.apache.storm.utils.ShellUtils;
     import org.apache.storm.utils.Utils;
     import org.slf4j.Logger;
     import org.slf4j.LoggerFactory;
     
     public class ClientSupervisorUtils {
    +    public static final Meter numWorkerLaunchExceptions = 
ShellUtils.numShellExceptions;
    --- End diff --
    
    I would like to see some comments so people can understand why 
`ClientSupervisorUtils` is using the same meter with `ShellUtils`


---

Reply via email to