Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2764#discussion_r203726617
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/daemon/metrics/reporters/ConsolePreparableReporter.java
 ---
    @@ -52,6 +52,7 @@ public void prepare(MetricRegistry metricsRegistry, 
Map<String, Object> topoConf
         public void start() {
             if (reporter != null) {
                 LOG.debug("Starting...");
    +            //TODO: will we make the period customizable?
    --- End diff --
    
    Please either raise an issue for this or remove the TODO. They have a habit 
of getting put in the code and then forgotten.


---

Reply via email to