Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208720133
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -735,39 +756,108 @@ private static int
numUsedWorkers(SchedulerAssignment assignment) {
return ret;
}
- private static Map<String, Map<List<Long>, List<Object>>>
computeNewTopoToExecToNodePort(
- Map<String, SchedulerAssignment> schedAssignments, Map<String,
Assignment> existingAssignments) {
- Map<String, Map<List<Long>, List<Object>>> ret =
computeTopoToExecToNodePort(schedAssignments);
- // Print some useful information
- if (existingAssignments != null && !existingAssignments.isEmpty())
{
- for (Entry<String, Map<List<Long>, List<Object>>> entry :
ret.entrySet()) {
- String topoId = entry.getKey();
- Map<List<Long>, List<Object>> execToNodePort =
entry.getValue();
- Assignment assignment = existingAssignments.get(topoId);
- if (assignment == null) {
- continue;
+ private boolean inspectSchduling(Map<String, Assignment>
existingAssignments,
--- End diff --
The name is a little vague. How about `calculateAssignmentChanged` or
something like that? Also there's a missing e in scheduling.
---
