[GitHub] storm pull request #2764: STORM-3147: Port ClusterSummary as metrics to Stor...

[srdo]

Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2764#discussion_r208703338
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
    @@ -411,6 +431,10 @@
         private final StormTimer timer;
         private final IScheduler scheduler;
         private final IScheduler underlyingScheduler;
    +    //Metrics related
    +    private final AtomicReference<Long> schedulingStartTime = new 
AtomicReference<>(null);
    --- End diff --
    
    Nit: Consider renaming these so it's obvious what time unit it is, e.g. 
`schedulingStartTimeNanos`


---