Ethanlm commented on pull request #3380:
URL: https://github.com/apache/storm/pull/3380#issuecomment-800610561


   This works nicely for this particular purpose within Intelij IDE.
   
   But is there any side effect? 
   
   From the description, 
https://www.mojohaus.org/build-helper-maven-plugin/attach-artifact-mojo.html, 
it says "Attach additional artifacts to be installed and deployed."
   
   I don't fully understand the meaning of it.  Will this attached artifact be 
deployed with `mvn install` or `mvn deploy`? 
   
   With `mvn install`, I saw 
   ```
   [INFO] --- maven-install-plugin:2.5.2:install (default-install) @ 
storm-shaded-deps ---
   [INFO] Installing 
/Users/ethanli/Workspace/community/storm/storm-shaded-deps/target/storm-shaded-deps-2.3.0-SNAPSHOT.jar
 to 
/Users/ethanli/.m2/repository/org/apache/storm/storm-shaded-deps/2.3.0-SNAPSHOT/storm-shaded-deps-2.3.0-SNAPSHOT.jar
   [INFO] Installing 
/Users/ethanli/Workspace/community/storm/storm-shaded-deps/dependency-reduced-pom.xml
 to 
/Users/ethanli/.m2/repository/org/apache/storm/storm-shaded-deps/2.3.0-SNAPSHOT/storm-shaded-deps-2.3.0-SNAPSHOT.pom
   [INFO] Installing 
/Users/ethanli/Workspace/community/storm/storm-shaded-deps/target/storm-shaded-deps-2.3.0-SNAPSHOT.jar
 to 
/Users/ethanli/.m2/repository/org/apache/storm/storm-shaded-deps/2.3.0-SNAPSHOT/storm-shaded-deps-2.3.0-SNAPSHOT-optional.jar
   ```
   that this storm-shaded-deps-2.3.0-SNAPSHOT.jar is installed twice into the 
local maven repo. I wonder if it will upload two copies of it to remote maven 
repo during `mvn deploy`. 
   
   I feel this side effect is not really desired. 
   
   I usually solve this intelij problem by this workaround: 
https://youtrack.jetbrains.com/issue/IDEA-126596#focus=Comments-27-757181.0-0
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to