bipinprasad commented on a change in pull request #3380:
URL: https://github.com/apache/storm/pull/3380#discussion_r598751559
##########
File path: storm-shaded-deps/pom.xml
##########
@@ -297,6 +297,28 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-pmd-plugin</artifactId>
</plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>build-helper-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>compile</id>
+ <phase>none</phase>
+ <goals>
+ <goal>attach-artifact</goal>
+ </goals>
+ <configuration>
+ <artifacts>
+ <artifact>
+
<file>${basedir}/target/storm-shaded-deps-${project.version}.jar</file>
Review comment:
This jar file has to be the one that was built (using the shade plugin).
Can't be an arbitrary or unavailable jar AFAIK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
