Ethanlm commented on a change in pull request #3380:
URL: https://github.com/apache/storm/pull/3380#discussion_r600705948
##########
File path: storm-shaded-deps/pom.xml
##########
@@ -297,6 +297,43 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-pmd-plugin</artifactId>
</plugin>
+ <plugin>
+ <!--
+ Purpose of build-helper-maven-plugin is to ensure that
IntelliJ sees shaded classes.
+ When navigating over to java classes in storm-client module,
the shaded imported classes will
+ show as resolved instead of unknown.
+ The artifact specified below is created when this module
(storm-shaded-deps) is built.
+ But is also used to resolve classes in IntelliJ.
+ "phase" is set to "none" - with this setting, the artifact jar
will not be uploaded to repo
+ when running standalone "mvn install" command.
+
+ (DO NOT DO THIS) If "phase" is changed to "package" then
standalone "mvn install" command will upload
+ this very same artifact as
storm-shaded-deps-${project.version}-optional.jar - which is not desired.
+
+ build-helper-maven-plugin can be removed completely with no
effect on the "mvn clean" and "mvn install",
+ which is handled by mvn-shade-plugin.
Review comment:
This should be `maven-shade-plugin`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
