[GitHub] [storm] bipinprasad commented on a diff in pull request #3479: [STORM-3832] Moving unit tests from junit4 to junit5

[GitBox]

bipinprasad commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r879800312


##########
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/spout/TestHdfsSpout.java:
##########
@@ -419,45 +419,45 @@ public void testMultipleFileConsumption_Ack() throws 
Exception {
             // read few lines from file1 dont ack
             runSpout(spout, "r3");
             FileReader reader = getField(spout, "reader");
-            Assert.assertNotNull(reader);
-            Assert.assertEquals(false, getBoolField(spout, 
"fileReadCompletely"));
+            assertNotNull(reader);
+            assertEquals(false, getBoolField(spout, "fileReadCompletely"));
 
             // read remaining lines
             runSpout(spout, "r3");
             reader = getField(spout, "reader");
-            Assert.assertNotNull(reader);
-            Assert.assertEquals(true, getBoolField(spout, 
"fileReadCompletely"));
+            assertNotNull(reader);
+            assertEquals(true, getBoolField(spout, "fileReadCompletely"));
 
             // ack few
             runSpout(spout, "a0", "a1", "a2");
             reader = getField(spout, "reader");
-            Assert.assertNotNull(reader);
-            Assert.assertEquals(true, getBoolField(spout, 
"fileReadCompletely"));
+            assertNotNull(reader);
+            assertEquals(true, getBoolField(spout, "fileReadCompletely"));
 
             //ack rest
             runSpout(spout, "a3", "a4");
             reader = getField(spout, "reader");
-            Assert.assertNull(reader);
-            Assert.assertEquals(true, getBoolField(spout, 
"fileReadCompletely"));
+            assertNull(reader);
+            assertEquals(true, getBoolField(spout, "fileReadCompletely"));
 
             // go to next file
             Path file2 = new Path(source.toString() + "/file2.txt");
             createTextFile(file2, 5);
 
             // Read 1 line
             runSpout(spout, "r1");
-            Assert.assertNotNull(getField(spout, "reader"));
-            Assert.assertEquals(false, getBoolField(spout, 
"fileReadCompletely"));
+            assertNotNull(getField(spout, "reader"));
+            assertEquals(false, getBoolField(spout, "fileReadCompletely"));
 
             // ack 1 tuple
             runSpout(spout, "a5");
-            Assert.assertNotNull(getField(spout, "reader"));
-            Assert.assertEquals(false, getBoolField(spout, 
"fileReadCompletely"));
+            assertNotNull(getField(spout, "reader"));
+            assertEquals(false, getBoolField(spout, "fileReadCompletely"));

Review Comment:
   use assertFalse



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org