bipinprasad commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r881054174
##########
storm-client/test/jvm/org/apache/storm/utils/UtilsTest.java:
##########
@@ -146,31 +146,31 @@ public void
getConfiguredClientThrowsRuntimeExceptionOnBadArgsTest() throws TTra
try {
new NimbusClient(config, "", 65535);
- Assert.fail("Expected exception to be thrown");
+ fail("Expected exception to be thrown");
} catch (RuntimeException e) {
- Assert.assertTrue(
- "Cause is not TTransportException " + e,
- Utils.exceptionCauseIsInstanceOf(TTransportException.class,
e));
+ assertTrue(
Review Comment:
assertThrows might be better here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
