[GitHub] [storm] bipinprasad commented on a diff in pull request #3479: [STORM-3832] Moving unit tests from junit4 to junit5

[GitBox]

bipinprasad commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r880988038


##########
storm-client/test/jvm/org/apache/storm/grouping/LoadAwareShuffleGroupingTest.java:
##########
@@ -385,12 +371,12 @@ private int[] 
runChooseTasksWithVerification(LoadAwareShuffleGrouping grouper, i
                 .chooseTasks(inputTaskId, Lists.newArrayList());
 
             // Validate a single task id return
-            assertNotNull("Not null taskId list returned", taskIds);
-            assertEquals("Single task Id returned", 1, taskIds.size());
+            assertNotNull(taskIds, "Not null taskId list returned");
+            assertEquals(1, taskIds.size(), "Single task Id returned");

Review Comment:
   error message should negate the assertion



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org