bipinprasad commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r881058354
##########
storm-server/src/test/java/org/apache/storm/DaemonConfigTest.java:
##########
@@ -50,45 +51,39 @@ private void stringOrStringListTest(String key) {
try {
conf.put(key, value);
ConfigValidation.validateFields(conf);
- Assert.fail("Expected Exception not Thrown for value: " +
value);
- } catch (IllegalArgumentException Ex) {
+ fail("Expected Exception not Thrown for value: " + value);
+ } catch (IllegalArgumentException ignore) {
}
}
Review Comment:
assertThrows(IllegalArgumentException.class), ...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
