bipinprasad commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r881958812
##########
storm-server/src/test/java/org/apache/storm/security/auth/DefaultHttpCredentialsPluginTest.java:
##########
@@ -18,30 +18,32 @@
import javax.security.auth.Subject;
import javax.servlet.http.HttpServletRequest;
import org.apache.storm.shade.com.google.common.collect.ImmutableSet;
-import org.junit.Assert;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
import org.mockito.Mockito;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
public class DefaultHttpCredentialsPluginTest {
@Test
public void test_getUserName() {
DefaultHttpCredentialsPlugin handler = new
DefaultHttpCredentialsPlugin();
- handler.prepare(new HashMap());
+ handler.prepare(new HashMap<>());
- Assert.assertNull("returns null when request is null",
handler.getUserName(null));
+ assertNull(handler.getUserName(null), "returns null when request is
null");
Review Comment:
negate error message where appropriate in this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
