[
https://issues.apache.org/jira/browse/STORM-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14143267#comment-14143267
]
ASF GitHub Bot commented on STORM-498:
--------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/256#issuecomment-56384816
Michael, I totally agree. That is why I gave this a +1. I plan on checking
it in shortly, which hopefully means today assuming things don't go too badly.
> storm-kafka: make ZK connection timeout configurable in Kafka spout
> -------------------------------------------------------------------
>
> Key: STORM-498
> URL: https://issues.apache.org/jira/browse/STORM-498
> Project: Apache Storm (Incubating)
> Issue Type: Improvement
> Affects Versions: 0.9.3-incubating
> Reporter: Michael Noll
> Assignee: Michael Noll
> Priority: Minor
>
> Currently the Kafka spout uses a hardcoded ZK connection timeout of 15
> seconds in
> {{external/storm-kafka/src/jvm/storm/kafka/DynamicBrokersReader.java}}:
> {code}
> _curator = CuratorFrameworkFactory.newClient(
> zkStr,
> Utils.getInt(conf.get(Config.STORM_ZOOKEEPER_SESSION_TIMEOUT)),
> 15000,
> new
> RetryNTimes(Utils.getInt(conf.get(Config.STORM_ZOOKEEPER_RETRY_TIMES)),
> Utils.getInt(conf.get(Config.STORM_ZOOKEEPER_RETRY_INTERVAL))));
> {code}
> We should make this setting configurable, similar to the ZK session timeout
> setting.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
