[
https://issues.apache.org/jira/browse/STORM-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14143794#comment-14143794
]
ASF GitHub Bot commented on STORM-498:
--------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/256#issuecomment-56440942
I am consistently getting NPE errors in several tests now.
```
Tests in error:
testMultiplePartitionsOnDifferentHosts(storm.kafka.DynamicBrokersReaderTest):
java.lang.RuntimeException: java.lang.NullPointerException
testMultiplePartitionsOnDifferentHosts(storm.kafka.DynamicBrokersReaderTest)
testSwitchHostForPartition(storm.kafka.DynamicBrokersReaderTest):
java.lang.RuntimeException: java.lang.NullPointerException
testSwitchHostForPartition(storm.kafka.DynamicBrokersReaderTest)
testGetBrokerInfo(storm.kafka.DynamicBrokersReaderTest):
java.lang.RuntimeException: java.lang.NullPointerException
testGetBrokerInfo(storm.kafka.DynamicBrokersReaderTest)
testMultiplePartitionsOnSameHost(storm.kafka.DynamicBrokersReaderTest):
java.lang.RuntimeException: java.lang.NullPointerException
testMultiplePartitionsOnSameHost(storm.kafka.DynamicBrokersReaderTest)
```
It looks like the config is not set and then the errors is just logged.
The NPE happens later on when it tries to use the client but it is NULL because
of the exception.
```
10463 [main] ERROR storm.kafka.DynamicBrokersReader - Couldn't connect to
zookeeper
java.lang.IllegalArgumentException: Don't know how to convert null to int
at backtype.storm.utils.Utils.getInt(Utils.java:301)
~[storm-core-0.9.3-incubating-SNAPSHOT.jar:0.9.3-incubating-SNAPSHOT]
at
storm.kafka.DynamicBrokersReader.<init>(DynamicBrokersReader.java:50)
~[classes/:na]
```
> storm-kafka: make ZK connection timeout configurable in Kafka spout
> -------------------------------------------------------------------
>
> Key: STORM-498
> URL: https://issues.apache.org/jira/browse/STORM-498
> Project: Apache Storm (Incubating)
> Issue Type: Improvement
> Affects Versions: 0.9.3-incubating
> Reporter: Michael Noll
> Assignee: Michael Noll
> Priority: Minor
>
> Currently the Kafka spout uses a hardcoded ZK connection timeout of 15
> seconds in
> {{external/storm-kafka/src/jvm/storm/kafka/DynamicBrokersReader.java}}:
> {code}
> _curator = CuratorFrameworkFactory.newClient(
> zkStr,
> Utils.getInt(conf.get(Config.STORM_ZOOKEEPER_SESSION_TIMEOUT)),
> 15000,
> new
> RetryNTimes(Utils.getInt(conf.get(Config.STORM_ZOOKEEPER_RETRY_TIMES)),
> Utils.getInt(conf.get(Config.STORM_ZOOKEEPER_RETRY_INTERVAL))));
> {code}
> We should make this setting configurable, similar to the ZK session timeout
> setting.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
