[
https://issues.apache.org/jira/browse/STORM-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144481#comment-14144481
]
ASF GitHub Bot commented on STORM-498:
--------------------------------------
GitHub user miguno opened a pull request:
https://github.com/apache/storm/pull/264
STORM-498: make ZK connection timeout configurable in Kafka spout
This change is backwards compatible to the previous semantics because
Storm's `defaults.yaml` sets the default ZK connection timeout to 15 seconds,
which is equal to the previously hardcoded timeout setting in the Kafka spout.
This pull request supersedes the previous pull request
https://github.com/apache/storm/pull/256, and fixes the NPE in the
`DynamicBrokersReaderTest` test suite.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/miguno/storm STORM-498
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/264.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #264
----
commit 2596e335f27a57784a93a57823bd93dde587909f
Author: Michael G. Noll <[email protected]>
Date: 2014-09-23T06:55:12Z
STORM-498: make ZK connection timeout configurable in Kafka spout
----
> storm-kafka: make ZK connection timeout configurable in Kafka spout
> -------------------------------------------------------------------
>
> Key: STORM-498
> URL: https://issues.apache.org/jira/browse/STORM-498
> Project: Apache Storm (Incubating)
> Issue Type: Improvement
> Affects Versions: 0.9.3-incubating
> Reporter: Michael Noll
> Assignee: Michael Noll
> Priority: Minor
>
> Currently the Kafka spout uses a hardcoded ZK connection timeout of 15
> seconds in
> {{external/storm-kafka/src/jvm/storm/kafka/DynamicBrokersReader.java}}:
> {code}
> _curator = CuratorFrameworkFactory.newClient(
> zkStr,
> Utils.getInt(conf.get(Config.STORM_ZOOKEEPER_SESSION_TIMEOUT)),
> 15000,
> new
> RetryNTimes(Utils.getInt(conf.get(Config.STORM_ZOOKEEPER_RETRY_TIMES)),
> Utils.getInt(conf.get(Config.STORM_ZOOKEEPER_RETRY_INTERVAL))));
> {code}
> We should make this setting configurable, similar to the ZK session timeout
> setting.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
