Hi Nirmal, >> >> Thanks for bringing that up. >> >> Since Kubernetes Group ID is given in the request body itself, > > > Are we adding it in request body or in the request path?
When deploying a new KubernetesGroup we are specifying the groupId in the request body itself. We are basically serializing the KubernetesGroup object which contains the groupId field. But when deploying a Kubernetes host, we are passing Kubernetes groupId in the request path. > >> >> shouldn't we make it PUT? Here is a good discussion about this on >> StackOverflow [1]. >> >> [1] http://stackoverflow.com/questions/630453/put-vs-post-in-rest >> >> On Fri, Sep 26, 2014 at 1:20 PM, Nirmal Fernando <nirmal070...@gmail.com> >> wrote: >> > >> > On Fri, Sep 26, 2014 at 1:17 PM, Akila Ravihansa Perera >> > <raviha...@wso2.com> >> > wrote: >> >> >> >> Thanks everyone for joining the call. Really sorry about the technical >> >> glitches we had to face during the Hangout. >> >> >> >> Here are the meeting notes; >> >> >> >> 1. Clean up the REST API. Change the REST APIs to adhere to RESTful >> >> design >> >> (not only limited to Kubernetes host registration) >> >> >> >> For eg - >> >> >> >> Deploying a new Kubernetes host - >> >> PUT /kubernetes/group/{kubernetesGroupId}/host >> >> >> >> >> >> Deploying a new Kubernetes group - >> >> PUT /kubernetes/group/ >> > >> > >> > These should be POST IMO. >> >> >> >> >> >> 2. Remove boolean return types in AutoScalerService interface >> >> >> >> >> >> Adding to that what I could not discuss: >> >> >> >> 1. Shall we rename KubernetesGroup -> KubernetesCluster to make the >> >> naming >> >> consistent? >> > >> > >> > +1 >> >> >> >> >> >> >> >> Thanks. >> > >> > >> > >> > >> > -- >> > Best Regards, >> > Nirmal >> > >> > Nirmal Fernando. >> > PPMC Member & Committer of Apache Stratos, >> > Senior Software Engineer, WSO2 Inc. >> > >> > Blog: http://nirmalfdo.blogspot.com/ >> >> >> >> -- >> Akila Ravihansa Perera >> Software Engineer, WSO2 >> >> Blog: http://ravihansa3000.blogspot.com > > > > > -- > Best Regards, > Nirmal > > Nirmal Fernando. > PPMC Member & Committer of Apache Stratos, > Senior Software Engineer, WSO2 Inc. > > Blog: http://nirmalfdo.blogspot.com/ -- Akila Ravihansa Perera Software Engineer, WSO2 Blog: http://ravihansa3000.blogspot.com
