I have done this. Thanks.
On Mon, Jan 5, 2015 at 10:14 PM, Reka Thirunavukkarasu <r...@wso2.com> wrote: > Sorry..I was not upto date..That's great.. > > Thanks, > Reka > > On Mon, Jan 5, 2015 at 9:32 AM, Rajkumar Rajaratnam <rajkum...@wso2.com> > wrote: > >> Hi Reka, >> >> Thanks for the ack! >> >> Lahiru already merged AbstractClusterMonitor into ClusterMonitor. We >> don't have AbstractClusterMonitor now :) >> >> So better to drop this ClusterMonitorFactory too. Will do. >> >> Thanks. >> >> On Mon, Jan 5, 2015 at 9:59 PM, Reka Thirunavukkarasu <r...@wso2.com> >> wrote: >> >>> +1. We can move this to MonitorFactory as ClusterMonitor is also a >>> Monitor. Also, please do consider whether we will need >>> AbstractClusterMonitor as ClusterMonitor is the the only child class of >>> AbstractClusterMonitor AFAIK. But, if we need the AbstractClusterMonitor in >>> future at some point, then i'm +1 to keep it as well.. >>> >>> Thanks, >>> Reka >>> >>> On Mon, Jan 5, 2015 at 8:34 AM, Rajkumar Rajaratnam <rajkum...@wso2.com> >>> wrote: >>> >>>> If you look at the ClusterMonitorFactory class, there are only a few >>>> lines of code. There is no need to have a separate factory for cluster >>>> monitors. We can move this to MonitorFactory class which has the factory >>>> method for other monitors such as group monitor and application monitor. >>>> >>>> Thanks. >>>> >>>> On Mon, Jan 5, 2015 at 4:36 PM, Rajkumar Rajaratnam <rajkum...@wso2.com >>>> > wrote: >>>> >>>>> Hi Devs, >>>>> >>>>> We have a single cluster monitor now. >>>>> >>>>> I guess we can remove the factory class. >>>>> >>>>> wdyt? >>>>> >>>>> Thanks. >>>>> >>>>> -- >>>>> Rajkumar Rajaratnam >>>>> Committer & PMC Member, Apache Stratos >>>>> Software Engineer, WSO2 >>>>> >>>>> Mobile : +94777568639 >>>>> Blog : rajkumarr.com >>>>> >>>> >>>> >>>> >>>> -- >>>> Rajkumar Rajaratnam >>>> Committer & PMC Member, Apache Stratos >>>> Software Engineer, WSO2 >>>> >>>> Mobile : +94777568639 >>>> Blog : rajkumarr.com >>>> >>> >>> >>> >>> -- >>> Reka Thirunavukkarasu >>> Senior Software Engineer, >>> WSO2, Inc.:http://wso2.com, >>> Mobile: +94776442007 >>> >>> >>> >> >> >> -- >> Rajkumar Rajaratnam >> Committer & PMC Member, Apache Stratos >> Software Engineer, WSO2 >> >> Mobile : +94777568639 >> Blog : rajkumarr.com >> > > > > -- > Reka Thirunavukkarasu > Senior Software Engineer, > WSO2, Inc.:http://wso2.com, > Mobile: +94776442007 > > > -- Rajkumar Rajaratnam Committer & PMC Member, Apache Stratos Software Engineer, WSO2 Mobile : +94777568639 Blog : rajkumarr.com
