bossenti commented on PR #2616: URL: https://github.com/apache/streampipes/pull/2616#issuecomment-2017624137
> Currently, the number data type is handled inconsistently in StreamPipes. Sometimes the **data type** and sometimes the **semantic data type** is checked. My suggestion would be the following: - Remove `'http://www.w3.org/2001/XMLSchema#number` from the data type and use only basic data types - Move `SemanticTypeService.isNumber` to `DataTypeService` and check the type instead of the semantic type (`domainProperties`) As already indicated by my review comments, I'm in favor of your suggestion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
