dominikriemer commented on PR #2616: URL: https://github.com/apache/streampipes/pull/2616#issuecomment-2024067018
> > Currently, the number data type is handled inconsistently in StreamPipes. Sometimes the **data type** and sometimes the **semantic data type** is checked. My suggestion would be the following: - Remove `'http://www.w3.org/2001/XMLSchema#number` from the data type and use only basic data types - Move `SemanticTypeService.isNumber` to `DataTypeService` and check the type instead of the semantic type (`domainProperties`) > > As already indicated by my review comments, I'm in favor of your suggestion We need to be careful when changing data types since these are also used by the core (e.g., by the matching feature). Some UI features such as the field selection in the data explorer also depend on these XSD defintions which are provided by the backend. So I'm afraid we can't simplify these identifiers safely without major migration effort. I think the code structure of the refactoring looks good apart from that. Just be careful when importing `platform-services` dependencies. Due to a misconfiguration in the `tsconfig` file, the IDE often imports these as relative dependencies instead of the correct `@streampipes/platform-services` import, which causes component collisions at build time. I have already started to improve the typescript config in the Angular 17 branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
