bossenti commented on PR #2616:
URL: https://github.com/apache/streampipes/pull/2616#issuecomment-2017635714

   > Should we rename `DataTypeService` to `DataType` & `SemanticTypeService` 
to `SemanticType`? Because it only contains static variables and there is no 
need to inject the service into components.
   
   From my point of view the `Service` as part of class names is slightly 
misleading, but I'm also not familiar with the naming conventions in Angular & 
TypeScript.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to