DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=34849>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34849





------- Additional Comments From [EMAIL PROTECTED]  2005-05-27 20:33 -------
(In reply to comment #15)
> Also theres an existing alternative solution - we already have 
> an IteratorAdapter in the utils package - changing the method [i.e. 
> PageContextImpl.getAttributeNamesInScope()] to return an Iterator rather than 
> an Enumeration would mean there would be no need to add/copy any additonal 
> classes to struts. 

IteratorAdapter is also in collection package - IteratorUtils.asIterator, and is
duplicated in struts package because someone did not want to create dependency
on collections.

The PageContext (via JspContext) defines returing type for
getAttributeNamesInScope() as Enumeration so I guess changing it to Iterator is
not a very good idea.

I am still not sure which option would be the best - whether to include the
collections or create another class that is in colection and duplicates the code
in struts package. Afaik org.apache.struts.mock.MockEnumeration has almost the
same code as IteratorEnumeration - so is should not be private and it should be
reused.

EnumeratedMap I guess should be private class.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to