I spent some time yesterday looking at what's left wrt the sample apps.
From struts/action/ I can execute the following:
$mvn (which runs the install target by default)
Looks like all artifacts are built correctly, so I proceeded to
deploy all of the web apps...
struts-cookbook
- was missing dependency on taglib -> fixed
- I went through all of the examples and they seem to run ok
strutsel-exercise-taglib
- href link from /logic-redirect.jsp redirects to
port 9090 -> fixed
(changed to redirect to root of application)
struts-mailreader
- good to go
(Does the web tests work for this yet?)
struts-blank
- looks good
struts-examples
- looks good
struts-faces-example1
struts-faces-example2
- not working atm
struts-scripting-mailreader
- The way I brought this app up to 1.3.x, was to copy the
latest mailreader and apply the changes manually.
One caveat to note though is that session management is
handled differently now in the mailreader app than it was
with earlier versions. The BaseAction checks for a user
bean in the session. I don't know how to do inheritence
in groovy, so I'll punt on that for now.
I also spent some time looking at the site docs. They all seemed to
run ok, and although I had to run the top level separately from
action1, they look fine.
So, what's next?
--
James Mitchell
On Apr 6, 2006, at 4:31 PM, Don Brown wrote:
Ok, I'm working with Wendy to do the Maven 2 conversion. Here is
the plan we have decided on:
1. All the jar artifacts (core, taglib, el, faces, scripting,
extras) get their own directory and pom
2. All the war artifacts, including the example apps from modules
like faces and scripting, will be moved into the apps/ directory,
which will be moved over to Maven 2 as well
3. Therefore, the immediate goal for the wars is to have all of
them reside in apps/, making building and testing easier
4. The end goal for the example wars will be to allow each module
to perhaps define its own sample Struts module, with a Maven plugin
that collects all the samples into one war. Cocoon does this with
their blocks with good effect. It makes it easy for users to see
all the possibilities without having to deploy a bunch of wars.
As a result, we'll be doing some restructuring, particularly to
Faces. Please let us know soon if anyone has any objections.
Don
Martin Cooper wrote:
On 4/5/06, James Mitchell <[EMAIL PROTECTED]> wrote:
I'd like to address some the current [action 1] build issues. Now
that we've simplified the directory structure (thanks Don!), I'd
like
to spend some time on our build process.
Please comment on the following, if I don't hear back soon I'll go
ahead and take care of these...
1. sample apps
action/apps/blank
- I think we should remove the dependency on tiles, blank should
not be an empty showcase for how to work with tiles.
Fine with me.
2. Dependency declarations are inconsistent. For example, some Maven
1 targets end with...
...
...
struts-tiles-1.3.1-SNAPSHOT.jar (try downloading from http://
struts.apache.org/)
struts-core-1.3.2-SNAPSHOT.jar (try downloading from http://
struts.apache.org/)
struts-extras-1.3.2-SNAPSHOT.jar (try downloading from http://
struts.apache.org/download.cgi)
struts-taglib-1.3.2-SNAPSHOT.jar (try downloading from http://
struts.apache.org/download.cgi)
...
...
So, is it 1.3.1 or 1.3.2? Is it download.cgi or the root of the
project site?
The project root seems less likely to move. ;-)
And a few more questions:
Q. We have a Maven 1 and Maven 2 build available, is this really
necessary? Why not just go with Maven 2?
If we have, or can get, our M2 build to at least the functionality
of our M1
build, I'd be in favour of dumping the M1 build now.
Q. I know there was apprehension about moving to Maven 2 a while back
because of the lack of plugins compared to maven 1. Is this still
the case?
I'll trust Wendy on this one, since I haven't gone and compared
what we have
in M1 to what's available in M2. The array of plugins available
for M2 is
mind-boggling, though.
Q. How many other committers are committed to learning and perfecting
our Maven 1 and/or 2 builds?
I have been spending a *lot* of time with M2 in my day job recently,
including writing some tricky custom Mojos, so I'm certainly up
for helping
out with the M2 build. As for M1, now that I've got my head around
M2, I'd
prefer not to try to keep two versions of Maven in my head. ;-)
--
Martin Cooper
Q. What is the difference between these?
sandbox/tiles/tiles-documentation
sandbox/tiles-documentation
I have more, but I'll fire this off for now...
--
James Mitchell
--------------------------------------------------------------------
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
