>> I much prefer a strong decoupling between layers, and accessing Servlet spec artifacts is a smell.
Decoupling between layers is definitely a good thing, but wouldn't the servlet API and Struts actions both be considered the controller layer? Assuming so, why do you think accessing the Servlet API from the controller layer is a smell? I could see a facade being good if it provides a better, more modern API (Servlet is pretty old), but I don't see how its a smell. On Mon, Dec 15, 2014 at 6:03 PM, Dave Newton <davelnew...@gmail.com> wrote: > > I think it's just that-a last ditch fallback. > > I much prefer a strong decoupling between layers, and accessing Servlet > spec artifacts is a smell. > On Dec 15, 2014 5:49 PM, "Paul Benedict" <pbened...@apache.org> wrote: > > > Why do you guys find it bad to access the raw request/response? I haven't > > found a problem doing that as a fallback. I'd like to know what you > think. > > > > > > Cheers, > > Paul > > > > On Mon, Dec 15, 2014 at 10:23 AM, Ken McWilliams < > ken.mcwilli...@gmail.com > > > > > wrote: > > > > > > +1 for the request/response wrappers. Have you had a chance to check > out: > > > https://tiles.apache.org/tiles-request/ ? > > > +1 for getting rid of Strings. Could see the benefit of what you say, > but > > > if you only meant getting rid of const Strings in favour of enums that > > > alone would be pretty nice. > > > > > > > > > > > > On Sun, Dec 14, 2014 at 9:22 AM, Dave Newton <davelnew...@gmail.com> > > > wrote: > > > > > > > > Lukasz Lenart wrote: > > > > > > > > > > Request/Response wrappers > > > > > Right now user can access raw Request or Response [...] > > > > > > > > > > > > Seems reasonable, although I wonder if the appearance of not being > able > > > to > > > > get the raw request/response will make people run away--they're very > > used > > > > to doing things icky. > > > > > > > > > > > > > No more Strings > > > > > We are passing Strings all over the framework - they represents > > > > > expressions, parameters and other different things. > > > > > > > > > > > > Strings are horrible things; +bunches. > > > > > > > > Even if they're just thin wrappers, so-called "micro types" can help > a > > > lot > > > > when trying to understand what's happened, and why. > > > > > > > > d. > > > > > > > > > >
