Well if you're implementing a custom result type for which a currently defined method does not exists, then you'll probably touch the response. Although everything normal is covered. But why would you need to touch the request (the raw request object and not an Aware-Interface) when using Struts2? It just makes things more complicated. Also if you need the actual request and start to pass it around it makes testing harder. Then because of those issues people wrap the request but with the array of tools out there everyone creates their own slightly different wrapper, the aforementioned request framework (tiles-request) tries to find middle ground and tries to translate between the known common types.
On Mon, Dec 15, 2014 at 3:49 PM, Paul Benedict <pbened...@apache.org> wrote: > > Why do you guys find it bad to access the raw request/response? I haven't > found a problem doing that as a fallback. I'd like to know what you think. > > > Cheers, > Paul > > On Mon, Dec 15, 2014 at 10:23 AM, Ken McWilliams <ken.mcwilli...@gmail.com > > > wrote: > > > > +1 for the request/response wrappers. Have you had a chance to check out: > > https://tiles.apache.org/tiles-request/ ? > > +1 for getting rid of Strings. Could see the benefit of what you say, but > > if you only meant getting rid of const Strings in favour of enums that > > alone would be pretty nice. > > > > > > > > On Sun, Dec 14, 2014 at 9:22 AM, Dave Newton <davelnew...@gmail.com> > > wrote: > > > > > > Lukasz Lenart wrote: > > > > > > > > Request/Response wrappers > > > > Right now user can access raw Request or Response [...] > > > > > > > > > Seems reasonable, although I wonder if the appearance of not being able > > to > > > get the raw request/response will make people run away--they're very > used > > > to doing things icky. > > > > > > > > > > No more Strings > > > > We are passing Strings all over the framework - they represents > > > > expressions, parameters and other different things. > > > > > > > > > Strings are horrible things; +bunches. > > > > > > Even if they're just thin wrappers, so-called "micro types" can help a > > lot > > > when trying to understand what's happened, and why. > > > > > > d. > > > > > >
