I believe this can be the strong reason to stop the release and work on the issue. @Tai Dupree<mailto:tdupree...@gmail.com> I think this is a strong reason to block the release, as things are severely broken.
Pankaj From: Pankaj soni <pankajsoni.m...@gmail.com> Sent: Friday, March 17, 2023 10:36 AM To: dev@superset.apache.org Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2 [EXTERNAL EMAIL] Sorry to say, but nothing works to fix alert and report. Not only screenshot but also simple reports are getting timeout error. Overall alert and report is completely broken and not working in any way. Thanks, Pankaj On Thu, 16 Mar, 2023, 06:31 Tai Dupree, <tdupree...@gmail.com<mailto:tdupree...@gmail.com>> wrote: FWIW, here's a fix PR https://github.com/apache/superset/pull/23388 [github.com]<https://urldefense.com/v3/__https:/github.com/apache/superset/pull/23388__;!!LpKI!gyu3rJ2UYcYDF7SmrFHvAmciKOhW-AJs4r-QcFFy_2y-CNVnMQM_d0NzEwujqDb4Dz3A7TV_yeJeOUPCgjwaQmH8WQ$> On Wed, Mar 15, 2023 at 11:22 AM Tai Dupree <tdupree...@gmail.com<mailto:tdupree...@gmail.com>> wrote: > Hi, > > So for the alerts/reports issue this config needs to be overridden: > https://github.com/apache/superset/blob/da3791ad3daa209631a588394600d1a8b635e814/superset/config.py#L1307 > > [github.com]<https://urldefense.com/v3/__https:/github.com/apache/superset/blob/da3791ad3daa209631a588394600d1a8b635e814/superset/config.py*L1307__;Iw!!LpKI!gyu3rJ2UYcYDF7SmrFHvAmciKOhW-AJs4r-QcFFy_2y-CNVnMQM_d0NzEwujqDb4Dz3A7TV_yeJeOUPCgjw-fS4WjA$> > > I suppose these defaults no longer work with the new Firefox/webdriver > version. They also seem chrome specific too, so probably don't make sense > as a default. I don't think this should block the release though since the > firefox/webdriver is only part of the dev image and not part of any > official release. Maybe we can just add a note in upgrading for this. > > > > On Wed, Mar 15, 2023 at 9:00 AM Sam Firke > <samuel.fi...@gmail.com<mailto:samuel.fi...@gmail.com>> wrote: > >> I'm also seeing errors with Alerts and Reports in rc2. Looking at the logs >> it appears to be this issue: >> https://github.com/apache/superset/issues/22326 >> [github.com]<https://urldefense.com/v3/__https:/github.com/apache/superset/issues/22326__;!!LpKI!gyu3rJ2UYcYDF7SmrFHvAmciKOhW-AJs4r-QcFFy_2y-CNVnMQM_d0NzEwujqDb4Dz3A7TV_yeJeOUPCgjypSPuseg$> >> >> On Wed, Mar 15, 2023, 5:27 AM Pankaj soni >> <pankajsoni.m...@gmail.com<mailto:pankajsoni.m...@gmail.com>> >> wrote: >> >> > Not able to send alerts, screenshot as alerts and reports as well. >> > >> > On Wed, 15 Mar, 2023, 14:42 Pankaj soni, >> > <pankajsoni.m...@gmail.com<mailto:pankajsoni.m...@gmail.com>> >> > wrote: >> > >> > > -1: Alert & Report section is completely broken as no mails, >> screenshots >> > > are triggered due to error mentioned in image >> > > >> > > On Tue, 14 Mar, 2023, 07:05 Elizabeth Thompson, >> > > <elizab...@preset.io.invalid<mailto:elizab...@preset.io.invalid>> wrote: >> > > >> > >> Hello Superset Community, >> > >> >> > >> This is a call for the vote to release Apache Superset version 2.1.0. >> > >> >> > >> The release candidate: >> > >> https://dist.apache.org/repos/dist/dev/superset/2.1.0rc2/ >> > >> [dist.apache.org]<https://urldefense.com/v3/__https:/dist.apache.org/repos/dist/dev/superset/2.1.0rc2/__;!!LpKI!gyu3rJ2UYcYDF7SmrFHvAmciKOhW-AJs4r-QcFFy_2y-CNVnMQM_d0NzEwujqDb4Dz3A7TV_yeJeOUPCgjxoge6aUA$> >> > >> >> > >> Git tag for the release: >> > >> https://github.com/apache/superset/tree/2.1.0rc2 >> > >> [github.com]<https://urldefense.com/v3/__https:/github.com/apache/superset/tree/2.1.0rc2__;!!LpKI!gyu3rJ2UYcYDF7SmrFHvAmciKOhW-AJs4r-QcFFy_2y-CNVnMQM_d0NzEwujqDb4Dz3A7TV_yeJeOUPCgjzePMQJGg$> >> > >> >> > >> The Change Log for the release: >> > >> https://github.com/apache/superset/blob/2.1.0rc2/CHANGELOG.md >> > >> [github.com]<https://urldefense.com/v3/__https:/github.com/apache/superset/blob/2.1.0rc2/CHANGELOG.md__;!!LpKI!gyu3rJ2UYcYDF7SmrFHvAmciKOhW-AJs4r-QcFFy_2y-CNVnMQM_d0NzEwujqDb4Dz3A7TV_yeJeOUPCgjyJnTVbhg$> >> > >> >> > >> The Updating instructions for the release: >> > >> https://github.com/apache/superset/blob/2.1.0rc2/UPDATING.md >> > >> [github.com]<https://urldefense.com/v3/__https:/github.com/apache/superset/blob/2.1.0rc2/UPDATING.md__;!!LpKI!gyu3rJ2UYcYDF7SmrFHvAmciKOhW-AJs4r-QcFFy_2y-CNVnMQM_d0NzEwujqDb4Dz3A7TV_yeJeOUPCgjzx2WpCFQ$> >> > >> >> > >> Public keys are available at: >> > >> https://www.apache.org/dist/superset/KEYS >> > >> [apache.org]<https://urldefense.com/v3/__https:/www.apache.org/dist/superset/KEYS__;!!LpKI!gyu3rJ2UYcYDF7SmrFHvAmciKOhW-AJs4r-QcFFy_2y-CNVnMQM_d0NzEwujqDb4Dz3A7TV_yeJeOUPCgjxq_xdJSQ$> >> > >> >> > >> The vote will be open for at least 72 hours or until the necessary >> > number >> > >> of votes are reached. >> > >> >> > >> Please vote accordingly: >> > >> >> > >> [ ] +1 approve >> > >> [ ] +0 no opinion >> > >> [ ] -1 disapprove with the reason >> > >> >> > >> Thanks, >> > >> The Apache Superset Team >> > >> >> > >> >> > >> > > > -- > -Tai Dupree > -- -Tai Dupree Internal Use - Confidential
