Personally, I believe that the out of the box support for alerts/reports is mostly provided for convenience so users can test the feature out and was never meant to be part of the official release distros (hence why driver support was only added to the dev image). However, I can already see the slew of questions and confusion from users not being able to use 2.1.0-dev image + default config to run alerts/reports.
Given that we've already identified and addressed the issue, I’m in favor of delaying this release in favor of an RC3 build with https://github.com/apache/superset/pull/23388 cherry-picked in. I vote -1 (binding) On Fri, Mar 17, 2023 at 12:26 PM Sam Firke <samuel.fi...@gmail.com> wrote: > I can confirm both that: > > - my reports broke with 2.1.0rc2, and > - they are now working, including attaching screenshots, using the docker > image with Tai's fixes: apache/superset:pr-23388-dev > > I vote -1 on 2.1.0rc2 as it breaks out-of-the-box reporting. But I think > Tai's PR provides a suitable fix for a next RC. And I see no other major > problems with rc2 that should hold up release. > > Sam > > On Fri, Mar 17, 2023 at 2:07 PM Tai Dupree <tdupree...@gmail.com> wrote: > > > Yes, I was able to receive an email report. You need to use an image > tagged > > with dev, you can try apache/superset:pr-23388-dev. > > > > On Fri, Mar 17, 2023 at 2:47 AM Soni, Pankaj > <pankaj.s...@dell.com.invalid > > > > > wrote: > > > > > Hi, > > > Are you also able to get screenshots in the mail? > > > As per your suggestion I tried your fix from recently pushed image: > > > "apache/superset:e3a7d2014df179088e14a5fc953dc66f69ba0f04-py39" > > > This incorporates the fix for webdriver. I am able to get reports but > > > still screenshot gives same error "Failed taking a screenshot Message: > > > 'geckodriver' executable needs to be in PATH" > > > > > > Thanks, > > > Pankaj > > > > > > > > > Internal Use - Confidential > > > > > > -----Original Message----- > > > From: Tai Dupree <tdupree...@gmail.com> > > > Sent: Friday, March 17, 2023 11:50 AM > > > To: dev@superset.apache.org > > > Subject: Re: [VOTE] Release Apache Superset 2.1.0 based on Superset > > > 2.1.0rc2 > > > > > > > > > [EXTERNAL EMAIL] > > > > > > I was just able to receive an email report just fine, so I don't think > > the > > > issue is with this release (aside from what's addressed in my PR). That > > > connection timeout error is usually networking/config related. Are you > > sure > > > you can reach the superset web server from the worker, and that smtp is > > > configured correctly? > > > > > > On Thu, Mar 16, 2023 at 10:58 PM multazim deshmukh < > multaz...@gmail.com> > > > wrote: > > > > > > > Hi Pankaj, > > > > > > > > Can you give more information to understand the root cause. > > > > 1. Did you upgrade to 2.1.0rc2 from a previous version? If so, which > > > > version? > > > > 2. Did you try Tai’s fix ? > > > > 3. Any details in the log? > > > > > > > > On Friday, March 17, 2023, Pankaj soni <pankajsoni.m...@gmail.com> > > > wrote: > > > > > > > > > Sorry to say, but nothing works to fix alert and report. > > > > > Not only screenshot but also simple reports are getting timeout > > error. > > > > > > > > > > Overall alert and report is completely broken and not working in > any > > > way. > > > > > > > > > > Thanks, > > > > > Pankaj > > > > > > > > > > On Thu, 16 Mar, 2023, 06:31 Tai Dupree, <tdupree...@gmail.com> > > wrote: > > > > > > > > > >> FWIW, here's a fix PR > > > > >> > https://urldefense.com/v3/__https://github.com/apache/superset/pull > > > > >> > /23388__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsmyMq_Tm > > > > >> Vaf5Y0ZM0tZx08OF9YD4rmT63sjVdu1A$ [github[.]com] > > > > >> > > > > >> On Wed, Mar 15, 2023 at 11:22 AM Tai Dupree <tdupree...@gmail.com > > > > > > wrote: > > > > >> > > > > >> > Hi, > > > > >> > > > > > >> > So for the alerts/reports issue this config needs to be > > overridden: > > > > >> > > > > > > https://urldefense.com/v3/__https://github.com/apache/superset/blob/da > > > > > 3791ad3daa209631a588394600d1__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9x > > > > z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63XwZHw3E$ [github[.]com] > > > > >> a8b635e814/superset/config.py#L1307 > > > > >> > > > > > >> > I suppose these defaults no longer work with the new > > > > >> > Firefox/webdriver version. They also seem chrome specific too, > so > > > > >> > probably don't make > > > > >> sense > > > > >> > as a default. I don't think this should block the release though > > > > >> > since > > > > >> the > > > > >> > firefox/webdriver is only part of the dev image and not part of > > > > >> > any official release. Maybe we can just add a note in upgrading > > for > > > this. > > > > >> > > > > > >> > > > > > >> > > > > > >> > On Wed, Mar 15, 2023 at 9:00 AM Sam Firke > > > > >> > <samuel.fi...@gmail.com> > > > > >> wrote: > > > > >> > > > > > >> >> I'm also seeing errors with Alerts and Reports in rc2. Looking > > > > >> >> at the > > > > >> logs > > > > >> >> it appears to be this issue: > > > > >> >> > https://urldefense.com/v3/__https://github.com/apache/superset/i > > > > >> >> > ssues/22326__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQ > > > > >> >> smyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63giKK5aw$ [github[.]com] > > > > >> >> > > > > >> >> On Wed, Mar 15, 2023, 5:27 AM Pankaj soni > > > > >> >> <pankajsoni.m...@gmail.com > > > > > > > > > >> >> wrote: > > > > >> >> > > > > >> >> > Not able to send alerts, screenshot as alerts and reports as > > > well. > > > > >> >> > > > > > >> >> > On Wed, 15 Mar, 2023, 14:42 Pankaj soni, < > > > > pankajsoni.m...@gmail.com> > > > > >> >> > wrote: > > > > >> >> > > > > > >> >> > > -1: Alert & Report section is completely broken as no > mails, > > > > >> >> screenshots > > > > >> >> > > are triggered due to error mentioned in image > > > > >> >> > > > > > > >> >> > > On Tue, 14 Mar, 2023, 07:05 Elizabeth Thompson, > > > > >> >> > > <elizab...@preset.io.invalid> wrote: > > > > >> >> > > > > > > >> >> > >> Hello Superset Community, > > > > >> >> > >> > > > > >> >> > >> This is a call for the vote to release Apache Superset > > > > >> >> > >> version > > > > >> 2.1.0. > > > > >> >> > >> > > > > >> >> > >> The release candidate: > > > > >> >> > >> > https://urldefense.com/v3/__https://dist.apache.org/repos/d > > > > >> >> > >> > ist/dev/superset/2.1.0rc2/__;!!LpKI!j4vMZKp0bgaggE6smVZkHUA > > > > >> >> > >> > uixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63PhlqEj > > > > >> >> > >> o$ [dist[.]apache[.]org] > > > > >> >> > >> > > > > >> >> > >> Git tag for the release: > > > > >> >> > >> > https://urldefense.com/v3/__https://github.com/apache/super > > > > >> >> > >> > set/tree/2.1.0rc2__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9x > > > > >> >> > >> z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63j9QUUPs$ > > > > >> >> > >> [github[.]com] > > > > >> >> > >> > > > > >> >> > >> The Change Log for the release: > > > > >> >> > >> > https://urldefense.com/v3/__https://github.com/apache/super > > > > >> >> > >> > set/blob/2.1.0rc2/CHANGELOG.md__;!!LpKI!j4vMZKp0bgaggE6smVZ > > > > >> >> > >> > kHUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63M- > > > > >> >> > >> MLnFs$ [github[.]com] > > > > >> >> > >> > > > > >> >> > >> The Updating instructions for the release: > > > > >> >> > >> > https://urldefense.com/v3/__https://github.com/apache/super > > > > >> >> > >> > set/blob/2.1.0rc2/UPDATING.md__;!!LpKI!j4vMZKp0bgaggE6smVZk > > > > >> >> > >> > HUAuixG90p9xz0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63_BM > > > > >> >> > >> pXQI$ [github[.]com] > > > > >> >> > >> > > > > >> >> > >> Public keys are available at: > > > > >> >> > >> > https://urldefense.com/v3/__https://www.apache.org/dist/sup > > > > >> >> > >> > erset/KEYS__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9 > > > > >> >> > >> RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63xX6J9hQ$ > > > > >> >> > >> [apache[.]org] > > > > >> >> > >> > > > > >> >> > >> The vote will be open for at least 72 hours or until the > > > > necessary > > > > >> >> > number > > > > >> >> > >> of votes are reached. > > > > >> >> > >> > > > > >> >> > >> Please vote accordingly: > > > > >> >> > >> > > > > >> >> > >> [ ] +1 approve > > > > >> >> > >> [ ] +0 no opinion > > > > >> >> > >> [ ] -1 disapprove with the reason > > > > >> >> > >> > > > > >> >> > >> Thanks, > > > > >> >> > >> The Apache Superset Team > > > > >> >> > >> > > > > >> >> > >> > > > > >> >> > > > > > >> >> > > > > >> > > > > > >> > > > > > >> > -- > > > > >> > -Tai Dupree > > > > >> > > > > > >> > > > > >> > > > > >> -- > > > > >> -Tai Dupree > > > > >> > > > > > > > > > > > > > -- > > > > Regards > > > > Multazim Deshmukh > > > > > https://urldefense.com/v3/__https://www.linkedin.com/in/multazim-deshm > > > > > ukh-a5b68429/__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9xz0Kpz_9RjgQsmyM > > > > q_TmVaf5Y0ZM0tZx08OF9YD4rmT63CPRFHeU$ [linkedin[.]com] > > > > > > > > > > > > > -- > > > -Tai Dupree > > > > > > > > > -- > > -Tai Dupree > > > -- -Tai Dupree
