williaster commented on a change in pull request #3581: Dashboard refactory
URL:
https://github.com/apache/incubator-superset/pull/3581#discussion_r147900238
##########
File path: superset/assets/javascripts/chart/Chart.jsx
##########
@@ -0,0 +1,190 @@
+/* eslint camelcase: 0 */
+import React from 'react';
+import PropTypes from 'prop-types';
+import Mustache from 'mustache';
+
+import { d3format } from '../modules/utils';
+import ChartBody from './ChartBody';
+import StackTraceMessage from '../components/StackTraceMessage';
+import visMap from '../../visualizations/main';
+
+const propTypes = {
+ actions: PropTypes.object,
+ chartKey: PropTypes.string.isRequired,
+ containerId: PropTypes.string.isRequired,
+ datasource: PropTypes.object.isRequired,
+ formData: PropTypes.object.isRequired,
+ height: PropTypes.number,
+ width: PropTypes.number,
+ setControlValue: PropTypes.func,
+ timeout: PropTypes.number,
+ viz_type: PropTypes.string.isRequired,
Review comment:
why do we not just `camelCase` this (and translate from underscore case in
the call to this component)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
