williaster commented on a change in pull request #3581: Dashboard refactory
URL:
https://github.com/apache/incubator-superset/pull/3581#discussion_r147900577
##########
File path: superset/assets/javascripts/chart/Chart.jsx
##########
@@ -0,0 +1,190 @@
+/* eslint camelcase: 0 */
+import React from 'react';
+import PropTypes from 'prop-types';
+import Mustache from 'mustache';
+
+import { d3format } from '../modules/utils';
+import ChartBody from './ChartBody';
+import StackTraceMessage from '../components/StackTraceMessage';
+import visMap from '../../visualizations/main';
+
+const propTypes = {
+ actions: PropTypes.object,
+ chartKey: PropTypes.string.isRequired,
+ containerId: PropTypes.string.isRequired,
+ datasource: PropTypes.object.isRequired,
+ formData: PropTypes.object.isRequired,
+ height: PropTypes.number,
+ width: PropTypes.number,
+ setControlValue: PropTypes.func,
+ timeout: PropTypes.number,
+ viz_type: PropTypes.string.isRequired,
+ // state
+ chartAlert: PropTypes.string,
+ chartStatus: PropTypes.string,
+ chartUpdateEndTime: PropTypes.number,
+ chartUpdateStartTime: PropTypes.number,
+ latestQueryFormData: PropTypes.object,
+ queryRequest: PropTypes.object,
+ queryResponse: PropTypes.object,
+ triggerRender: PropTypes.bool,
+ triggerQuery: PropTypes.bool,
+ // dashboard callbacks
+ addFilter: PropTypes.func,
+ getFilters: PropTypes.func,
+ clearFilter: PropTypes.func,
+ removeFilter: PropTypes.func,
+};
+
+const defaultProps = {
+ addFilter: () => {},
+ getFilters: () => ({}),
+ clearFilter: () => {},
+ removeFilter: () => {},
+};
+
+class Chart extends React.PureComponent {
+ constructor(props) {
+ super(props);
+
+ // these properties are used by visualizations
+ this.containerId = props.containerId;
+ this.selector = `#${this.containerId}`;
+ this.formData = props.formData;
+ this.datasource = props.datasource;
+ this.addFilter = this.addFilter.bind(this);
+ this.getFilters = this.getFilters.bind(this);
+ this.clearFilter = this.clearFilter.bind(this);
+ this.removeFilter = this.removeFilter.bind(this);
+ }
+
+ componentDidMount() {
+ this.runQuery();
+ }
+
+ componentWillReceiveProps(nextProps) {
+ this.containerId = nextProps.containerId;
+ this.selector = `#${this.containerId}`;
+ this.formData = nextProps.formData;
+ this.datasource = nextProps.datasource;
+ }
+
+ componentDidUpdate(prevProps) {
+ if (
+ this.props.queryResponse &&
+ this.props.chartStatus === 'success' &&
+ !this.props.queryResponse.error && (
+ prevProps.queryResponse !== this.props.queryResponse ||
Review comment:
nit I would indent everything within these `()` one level deeper
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
