williaster commented on a change in pull request #3581: Dashboard refactory
URL:
https://github.com/apache/incubator-superset/pull/3581#discussion_r149281425
##########
File path: superset/assets/javascripts/dashboard/components/Controls.jsx
##########
@@ -36,14 +45,16 @@ class Controls extends React.PureComponent {
}
refresh() {
// Force refresh all slices
- this.props.dashboard.renderSlices(this.props.dashboard.sliceObjects, true);
+ this.props.renderSlices(true);
}
changeCss(css) {
this.setState({ css });
- this.props.dashboard.onChange();
+ this.props.onChange();
}
render() {
- const dashboard = this.props.dashboard;
+ const { dashboard, userId,
Review comment:
nit it's more ideal to unpack these one per line because it makes git
history more informative (there is a lint rule for this we should enable
sometime in a bigger sweep)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
