williaster commented on a change in pull request #3581: Dashboard refactory
URL:
https://github.com/apache/incubator-superset/pull/3581#discussion_r149280724
##########
File path: superset/assets/javascripts/chart/chartReducer.js
##########
@@ -0,0 +1,100 @@
+/* eslint camelcase: 0 */
+import PropTypes from 'prop-types';
+
+import { now } from '../modules/dates';
+import * as actions from './chartAction';
+import { t } from '../locales';
+
+export const chartPropType = {
+ chartKey: PropTypes.string.isRequired,
+ chartAlert: PropTypes.string,
+ chartStatus: PropTypes.string,
+ chartUpdateEndTime: PropTypes.number,
+ chartUpdateStartTime: PropTypes.number,
+ latestQueryFormData: PropTypes.object,
+ queryResponse: PropTypes.object,
+ triggerQuery: PropTypes.bool,
+ lastRendered: PropTypes.number,
+};
+
+export const chart = {
+ chartKey: '',
+ chartAlert: null,
+ chartStatus: null,
+ chartUpdateEndTime: null,
+ chartUpdateStartTime: now(),
+ latestQueryFormData: null,
+ queryResponse: null,
+ triggerQuery: true,
+ lastRendered: 0,
+};
+
+export default function chartReducer(charts = {}, action) {
+ const actionHandlers = {
+ [actions.CHART_UPDATE_SUCCEEDED](state) {
+ return { ...state,
+ chartStatus: 'success',
+ queryResponse: action.queryResponse,
+ chartUpdateEndTime: now(),
+ };
+ },
+ [actions.CHART_UPDATE_STARTED](state) {
+ return { ...state,
+ chartStatus: 'loading',
+ chartUpdateEndTime: null,
+ chartUpdateStartTime: now(),
+ queryRequest: action.queryRequest,
+ };
+ },
+ [actions.CHART_UPDATE_STOPPED](state) {
+ return { ...state,
+ chartStatus: 'stopped',
+ chartAlert: t('Updating chart was stopped'),
+ };
+ },
+ [actions.CHART_RENDERING_FAILED](state) {
+ return { ...state,
+ chartStatus: 'failed',
+ chartAlert: t('An error occurred while rendering the visualization:
%s', action.error),
+ };
+ },
+ [actions.CHART_UPDATE_TIMEOUT](state) {
+ return { ...state,
+ chartStatus: 'failed',
+ chartAlert: (
+ "<strong>{t('Query timeout')}</strong> - " +
+ t(`visualization queries are set to timeout at ${action.timeout}
seconds. `) +
+ t('Perhaps your data has grown, your database is under unusual load, '
+
Review comment:
not a huge deal but these would ideally be `\``s not concatenations
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
