williaster commented on a change in pull request #3581: Dashboard refactory
URL:
https://github.com/apache/incubator-superset/pull/3581#discussion_r149288700
##########
File path: superset/assets/javascripts/dashboard/components/GridLayout.jsx
##########
@@ -14,117 +12,94 @@ const ResponsiveReactGridLayout =
WidthProvider(Responsive);
const propTypes = {
dashboard: PropTypes.object.isRequired,
+ datasources: PropTypes.object,
+ charts: PropTypes.object.isRequired,
+ filters: PropTypes.object,
+ timeout: PropTypes.number,
+ onChange: PropTypes.func,
+ getFormDataExtra: PropTypes.func,
+ fetchSlice: PropTypes.func,
Review comment:
it's harder to lint actions not being passed with this approach, unless you
defined a strict `PropTypes.shape` was defined
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
