[
https://issues.apache.org/jira/browse/SYNAPSE-715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amila Maharachchi updated SYNAPSE-715:
--------------------------------------
Attachment: synapse_nhttp_refactor.patch
I thought of introducing a new class ListenerContext and include those common
parameters in it. I also introduced another class RequestProcessingContext
which includes some parameters which are passed to the ServerWorker by the
ServerHandler. These entities are involved in processing the request. By
introducing these two classes I was able to make the code clear than the
existing one.
During this refactoring process, I added some missing documentation parts and
also corrected some spelling mistakes in the comments. Please go through the
patch I have provided and if it is suitable to be applied, please apply it.
If there are any improvements to be done in the patch provided please do
comment (If the class name RequestProcessingContext is not suitable, please
propose a suitable class name)
> Refactoring and improving the code in HttpCoreNIOListener, ServerHandler and
> ServerWorker classes
> -------------------------------------------------------------------------------------------------
>
> Key: SYNAPSE-715
> URL: https://issues.apache.org/jira/browse/SYNAPSE-715
> Project: Synapse
> Issue Type: Improvement
> Components: Transports
> Reporter: Amila Maharachchi
> Priority: Minor
> Attachments: synapse_nhttp_refactor.patch
>
>
> While I was going through the code of nhttp transport, I found some places
> where I thought the code can be refactored in order to make it more clear and
> nicer. Current code has quite a lot of parameters passing to the
> ServerHandler and ServerWorker contructors (respectively 8 and 11). There are
> quite a few common parameters among these which are passed from the
> HttpCoreNIOListener to ServerHandler and then to the ServerWorker.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
