[
https://issues.apache.org/jira/browse/SYNAPSE-715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979487#action_12979487
]
Amila Maharachchi commented on SYNAPSE-715:
-------------------------------------------
Thanks Ruwan and Supun for your kind suggestions. I will rename the
ListenerContext class to NhttpListenerContext (which will give a more clear
idea).
Regarding the refactoring of the sender, I didnt consider it because there is
no such issue (too many parameters being passed and code is not clear because
of it) in the sender. I'll consider creating a sender context too.
I'll also look at the mistakes done in mixing context and configuration and
come up with a suitable solution.
Will provide another patch after resolving the above mentioned issues.
Meanwhile, any other feedbacks are welcome.
Thanks,
Amila.
> Refactoring and improving the code in HttpCoreNIOListener, ServerHandler and
> ServerWorker classes
> -------------------------------------------------------------------------------------------------
>
> Key: SYNAPSE-715
> URL: https://issues.apache.org/jira/browse/SYNAPSE-715
> Project: Synapse
> Issue Type: Improvement
> Components: Transports
> Reporter: Amila Maharachchi
> Priority: Minor
> Attachments: synapse_nhttp_refactor.patch,
> synapse_nhttp_refactor_2.patch
>
>
> While I was going through the code of nhttp transport, I found some places
> where I thought the code can be refactored in order to make it more clear and
> nicer. Current code has quite a lot of parameters passing to the
> ServerHandler and ServerWorker contructors (respectively 8 and 11). There are
> quite a few common parameters among these which are passed from the
> HttpCoreNIOListener to ServerHandler and then to the ServerWorker.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
