[
https://issues.apache.org/jira/browse/SYNAPSE-715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979481#action_12979481
]
Ruwan Linton commented on SYNAPSE-715:
--------------------------------------
1. It looks to me that you have mixed context information and the configuration
information both on this new context, I guess it is good to separate out
configurations from the Context information. I guess there is already a
NhttpConfiguration class?
2. The name ListenerContext is too abstract, ListenerContext gives me the
understanding that this is commons to all axis2 transports, but it is not.
3. Why don't we do the same for the sender as well, otherwise it is
inconsistent.
Supun, why do you think it should be named ListenerRequest?? It is not a
request?
> Refactoring and improving the code in HttpCoreNIOListener, ServerHandler and
> ServerWorker classes
> -------------------------------------------------------------------------------------------------
>
> Key: SYNAPSE-715
> URL: https://issues.apache.org/jira/browse/SYNAPSE-715
> Project: Synapse
> Issue Type: Improvement
> Components: Transports
> Reporter: Amila Maharachchi
> Priority: Minor
> Attachments: synapse_nhttp_refactor.patch,
> synapse_nhttp_refactor_2.patch
>
>
> While I was going through the code of nhttp transport, I found some places
> where I thought the code can be refactored in order to make it more clear and
> nicer. Current code has quite a lot of parameters passing to the
> ServerHandler and ServerWorker contructors (respectively 8 and 11). There are
> quite a few common parameters among these which are passed from the
> HttpCoreNIOListener to ServerHandler and then to the ServerWorker.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
