Baunsgaard commented on code in PR #1698:
URL: https://github.com/apache/systemds/pull/1698#discussion_r979897835
##########
src/test/java/org/apache/sysds/test/functions/federated/monitoring/FederatedWorkerStatisticsTest.java:
##########
@@ -58,6 +87,54 @@ public void testWorkerStatisticsParsedCorrectly() {
Assert.assertNotEquals("Utilization stats parsed correctly", 0,
model.utilization.size());
}
+ @Test
+ public void testWorkerStatisticsPerformance() throws
InterruptedException {
Review Comment:
First, if the test does not take that long to make, keep it.
But if it is running for 50+ seconds we need to reconsider.
Ideally we should have a way to test the multiple tests, to verify that it
works with multiple worker threads underneath,
that run in reasonable time.
I think in this case you know best, so if it is not possible at the
moment/it takes to long for now we need to add a JIRA task for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
